Skip to content

feature/headsupdisplay disable for macos#199

Closed
sbvis wants to merge 1 commit into
masterfrom
feature/mac-build-fix
Closed

feature/headsupdisplay disable for macos#199
sbvis wants to merge 1 commit into
masterfrom
feature/mac-build-fix

Conversation

@sbvis

@sbvis sbvis commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@sbvis sbvis requested a review from ThomasKroes September 24, 2025 12:33
@sbvis

sbvis commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

Added a check for macos such that the updateHeadsUpDisplay is not called to fix the scatterplot crash

@alxvth

alxvth commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

What is the actual issue here? This does not seem to fix any underlying issue, but rather ignore it...

@sbvis

sbvis commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

When we open a scatterplot, it crashes on this line:
const auto datasetsItem = getHeadsUpDisplayAction().addHeadsUpDisplayItem("Datasets", "", "");

but does not show any useful error message.

Happens only on Mac and if there are datasets in the data hierarchy.

So, inorder to create the installer, I discussed with ThomasK and disabled it for Mac.

@sbvis sbvis closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants